Fallout 2 mod FO2 Engine Tweaks (Sfall)

Ok, I spent a few hours trying to to find the defines for some of the values but I just couldn't find them.

In criticals.cpp

I can see this:
#define SetEntry(critter, bodypart, effect, param, value)

and then looking at this
SetEntry(18, 0, 0, 5, 5001);

I can understand first value is critter (horigan), second is bodypart (0-7), third seems to be the critical lever (0-5)...

But the 4th and 5th value, I'm not understanding well. I think (but not sure) "param" decides which field (element) within the level to change (critical mult, critical flag, stat check, message, etc) , and the 5th sets the value of the field.


But I'm not clear how the param works. is it from 0-6 for each field from left to right as ordered according to the critical table posted on fandom?

And the values for the "VALUE" field I suppose should be different according what the param field number is. Have I got this right?

Is the "VALUE" field a decimal number representing the equivalent hex value?

 

They are the same as the arguments of set_critical_table script function.
4th: element/value type, 0-6 correspond to the columns in the critical hit tables. (0 - damage multiplier, 1 - effects, etc.)
5th: the value for the element, so it can be multiplier values, effects (DAM_* defines in Define.h header), SPECIAL stats (STAT_* in Define.h), or message numbers (in combat.msg)

 

Ok, Thanks so much man.

 

Are You sure, that You've configured ddraw.ini properly for the playback (and *indeed* playback the upscaled .avi videos insted of .mve) or do you just want to 'troll' me from a "NVIDIA card owner's" position? :p
i don't think the videos are alright at all. No matter what settings i use to cut them they always end up without sound and in turbo display mode ingame. My codecs must be ok since external aplication (i use Allplayer) plays back the video just fine.

Although the upscale AI I've installed for testing purposes did come with some codecs of it's own FFdd if i remember correctly. they're not installed separately in the system, however FFdd also come with CCCP codec pack which i do have installed.

 

NovaRain I read through criticals.cpp and noticed something which I think might be an error but I could be wrong. Wanna get clarification.

At line 168 the entry is:

Code:

SetEntry(4, 0, 4, 2, -1);

This translates to:
SetEntry(Ghouls, Head, 5th Crit_lvl, stat_check, value =-1)

This field sets which SPECIAL to be checked. Its endurance which should technically be checked.

The above line is saying -1 should be checked. My guess is Endurance Can't be -1.

I suppose stats should be from 0 to 6. ST, PE, EN, etc... 0, 1, 2, etc.

Am I mistaken about something? cause if not then my guess is that the value "-1" was probably intended for the "Modifier check" field and not the STAT check field.
And even if the value of this field is correct, then the next field (modifier check field) should technically hold a value, which it doesn't.

If I caught this right and I'm not mistaken, then the following line 170 has the same error.

Please confirm.

 

-1 means "no stat". If you read the notes at the button of the table on fandom you'd know why.

 

Of course right. I'm using these videos for further tests.

 

Oh yes. sorry about that. I have read that page so many times that I don't read those parts anymore, and had forgotten that note. my mistake.

 

Guess I'll wait for the results..

Anyway do you want the rest of those Fo1 upscaled videos? The rest didn't had to go through bandicut and I downloaded them with conversion through "Any Viideo Downloader". The rest of the videos I speak of seem to work fine for me, although Lexx said they work 'wonky' or something, whatever that was about.
Anyways whenever ending a playback of .avi videos in pipboy the game turns interface to black color. Simply refreshing the interface returns it to normal (although not the leather/metal sidebar art). This might be looked into as well.
If there are blue sidebars during playback, then there are no <moviename>.cfg files present.
Simply setting a fade in/out effect with colors set to 0,0,0 for "0" frame fixes this.

 

EDIT** shortening and updating.**


So the question was: when needing persistent arrays,

1. Where is best to create them within the script, and,
2. how to call them from other scripts.


Documentation says that permanent arrays (created, or fixed) can be accessed by any script



** Answer to first part is, Doesn't matter where you create them. Arrays are global. but the variable that holds its ID is local.

Still no answer for the second part. I'll update if I figure out.

 

sfall 4.2.8 and 3.8.28 are released on SourceForge, along with their respective modders packs.

 

That's awesome!

Just in time. I finished the other components and was just ready to work on tohit.

This release means a lot to me.


Regarding the new argument for COMBATDAMAGE, I suppose you can't use the normal "get_sfall_arg" on it, can you? what would it return?

Doc says use get/set_object_data. from anywhere?

What would be some use case examples of this argument? how can we use it to our advantage?

 

You can get it with normal get_sfall_arg just like other arguments. Don't know why you think it's different from others.
It's exactly the same as what the new "combat_data" returns: the pointer to the combat data.
Here's a simple example that replaces all player's critical hit messages with line 6500 from combat.msg.

Spoiler

Code:

#include ".\headers\define.h"
#include ".\headers\sfall\sfall.h"
#include ".\headers\sfall\define_extra.h"

procedure start;
procedure CombatDamageHandler;

procedure start begin
   if game_loaded then begin
      register_hook_proc(HOOK_COMBATDAMAGE, CombatDamageHandler);
   end
end

procedure CombatDamageHandler begin
   variable
      attacker        := get_sfall_arg_at(1),
      attackerResults := get_sfall_arg_at(5),
      combatData      := get_sfall_arg_at(12);

   if (attacker == dude_obj) and (attackerResults bwand DAM_CRITICAL) then begin
      set_object_data(combatData, C_ATTACK_MESSAGE, 6500);
   end
end

 

Ok I see. I forgot that there is a whole new function called combat data. I'll read the documentation on it first.


**EDIT:
OKAAY, looking silly over here. So I didn't find any new documentation added anywhere about combat data. But reading your example more carefully I realize there is no need for more documentation. Its just set_object_data, parameter, and value. Thanks.

 

I want to increase the open inventory AP_cost. Sfall gives this option in ddraw.ini. But I'm worried, if say I make the cost to be 8, will critters who have less than 8 AP be able to access their inventory at all then?

The ideal situation would be that AP formula for inventory be written as:

inventory_ap_cost = minimum of ( ini_number, critter_current_max_ap).

This would ensure that if the critter has less APs than the required number they would still be able to open their inventory if they haven't spent any action points this turn.

Is this how the code is written in sfall? or will setting the number to a high number like 8 or 10 cause problems?

If it causes problems then I would like to request that a simple fix like the above would be added to sfall to address it.

 

Have you tried set_inven_ap_cost?

 

There's STAT_max_move_points, but I'm not sure if that includes move-only points.
That can be compared to get_critter_current_ap.

 

Pretty sure NPCs don't open their Inventory, and just use items from their off-hand at the items AP cost. At least in vanilla that's how it used to be iirc (and I'm more versed in FO1 behavior there than 2 ^^).

 

Not yet but here is the thing; using set_inven_ap_cost It should be easy to do this in a script. But then this issue will exist for anyone who decides to raise the number, thinking it will be fine (when it might not be fine). In other words if the check is not written in sfall there always exists this problem for anyone who increases this number and they'd have to write a script to ensure no errors arise.



I'm just thinking it might be better to address it at the source instead of repeatedly for each individual mod. But I'm not 100% sure if it IS a problem. I don't know how sfall's code is written in this regard. What do you think?

So if they have multiple items, they grab directly without inven cost? If that's so then it should be fine then, but we should be sure. Cause if not then one can expect problems.

 

Oh also if set_inven_ap_cost sets the inventory access cost then this souldn't solve the problem because some critters still wouldn't meet the required APs. Unless if you're suggesting to change the AP cost over and over for each critter on their turn... I think that's a potentially troublesome solution or at least I don't know how to do it safely yet.